[12.x] Fixing RedisTaggedCache::flushValues with PredisClusterConnection #57848
+11
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #57714
Unskipping last tests in RedisStoreTest. They're failing with
Cannot use 'DEL' with redis-cluster(see https://github.com/laravel/framework/actions/runs/19557692214/job/56003381622?pr=57848).Unlike KEYS command from (#57841), DEL works correctly with PredisclusterConnection, if all of keys hashes to same slot. So just bringing new DEL implementation to PredisClusterConnection would change behavior, making multiple calls where previously was one.
So i fix only RedisTaggedCache::flushValues for such case. Assuming, if we are speaking about tagged cache, in most cases keys wil hash to different slots. So deleting each key separately, wrapping it with pipeline to reduce waiting.