Skip to content

[12.x] Improve type annotations to $depth and Filesystem::allDirectories() #57575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: 12.x
Choose a base branch
from
Draft

[12.x] Improve type annotations to $depth and Filesystem::allDirectories() #57575

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b44a626
Add type annotations to Finder::depth() in Filesystem
shaedrich Oct 29, 2025
6fa3a72
Add return type annotation to `Filesystem::allDirectories()`
shaedrich Oct 29, 2025
5819ad7
Correct variable name
shaedrich Oct 29, 2025
d55b0f2
Correct variable name
shaedrich Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Illuminate/Filesystem/Filesystem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,7 @@ public function glob($pattern, $flags = 0)
*
* @param string $directory
* @param bool $hidden
* @param string|int|string[]|int[] $depth
* @return \Symfony\Component\Finder\SplFileInfo[]
*/
public function files($directory, $hidden = false, array|string|int $depth = 0)
Expand All @@ -606,6 +607,7 @@ public function allFiles($directory, $hidden = false)
* Get all of the directories within a given directory.
*
* @param string $directory
* @param string|int|string[]|int[] $depth
* @return array
*/
public function directories($directory, array|string|int $depth = 0)
Expand All @@ -622,7 +624,7 @@ public function directories($directory, array|string|int $depth = 0)
/**
* Get all the directories within a given directory (recursive).
*
* @return array
* @return string[]
*/
public function allDirectories(string $directory): array
{
Expand Down