Skip to content

Conversation

alipowerful7
Copy link
Contributor

@alipowerful7 alipowerful7 commented Sep 27, 2025

before:

$this->offset(($page - 1) * $perPage)->limit($perPage + 1);

after:

$this->forPage($page, $perPage);

if method call with perPage 15 in this one

$this->offset(($page - 1) * $perPage)->limit($perPage + 1);

perPage is 16

@alipowerful7 alipowerful7 marked this pull request as draft September 27, 2025 14:35
@alipowerful7 alipowerful7 marked this pull request as ready for review September 27, 2025 14:37
@taylorotwell
Copy link
Member

If this is working I'd rather not change it.

@alipowerful7 alipowerful7 deleted the refactor/use-for-page-function branch September 28, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants