Skip to content

[12.x] Add enum support for job method in scheduler #56101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

amirhshokri
Copy link
Contributor

@amirhshokri amirhshokri commented Jun 22, 2025

This PR adds enum support for the $queue and $connection parameters in $schedule->job() method:

$schedule->job(TestJob::class, QueueType::DEFAULT, ConnectionType::REDIS);

@taylorotwell
Copy link
Member

I think I would prefer to have one unified PR to add Enum support to every single documented place in the framework it makes sense to use them vs. continuing to add support in one place at a time.

@amirhshokri
Copy link
Contributor Author

Thanks for reviewing the PR @taylorotwell
Do you mean these changes should be applied throughout the entire project, or just in the queue-related parts?
Because in the first case, the amount of changes would be quite large.

@shaedrich
Copy link
Contributor

If that was to happen, it would probably make sense to create a branch here directly and divide the work between different people 🤔

@amirhshokri amirhshokri deleted the add-enum-support-to-scheduler-job-method branch June 24, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants