Make class_uses_recursive() and trait_uses_recursive() helpers onceable #56069
+26
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsive() helpers onceable
Co-authored-by: Luke Kuzmish <lakuzmish@gmail.com> See https://github.styleci.io/analyses/xgkx70?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
weshooper
reviewed
Jun 18, 2025
weshooper
reviewed
Jun 18, 2025
Co-authored-by: Wes Hooper <weshooper@users.noreply.github.com> Co-authored-by: Wes Hooper <weshooper@users.noreply.github.com>
Co-authored-by: Wes Hooper <weshooper@users.noreply.github.com> Co-authored-by: Wes Hooper <weshooper@users.noreply.github.com>
|
I don't think you even need to use once. Just use a static variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes rarely change at runtime, however, checking their dependencies every time we need them—sometimes even recursively—can be expensive. So, caching them makes sense.
Suggested by @cosmastech
See: #56060 (comment)