[12.x] Update "Number::fileSize" to use correct prefix and add prefix param #55678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Number::fileSize
uses 1024 as base to do the calculations but labels it wrong. With base 1024 a binary prefix should be used.Normally people expect 1000 as base but for more technical applications base 1024 is needed. That's why there is now an optional parameter to use the binary prefix.
I also added
RB
/RiB
andQB
/QiB
to the units array.