[12.x] Add Support for Selective Relationship Autoloading in withRelationshipAutoloading #55673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
moe-mizrak
changed the title
|
moe-mizrak
changed the title
moe-mizrak
commented
May 8, 2025
| } | ||
| } | ||
|
|
||
| $this->loadMissingRelationshipChain($tuples); |
There was a problem hiding this comment.
todo: this part will be modified, can be improved overall
|
Not sure if its worth the complexity it adds up, abondening for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for selective column loading in
withRelationshipAutoloading, similar to howwith('client:id,name')works.Please refer to withRelationshipAutoloading
With this enhancement, you can now specify which columns to load for a relationship, improving query performance by only retrieving the necessary data.
For example:
Note
Backward compatibility is preserved:
When no columns are specified for a relationship, all columns continue to load by default. Other relationships continue autoloading as expected without needing to be explicitly defined.