Add descriptive error messages to assertViewHas() #55392
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement:
Currently, when passing multiple key-value pairs to assertViewHasAll() and an error occurs, there is no feedback to which of the many fields caused the assertion to fail. Not even the stacktrace and line numbers provide sufficient information.
Example:
Before:
Solution:
This PR adds custom error messages to the underlying assertions to give the user better feedback, which of the fields caused the assertion error.
Please feel free to make any suggestions regarding the exact text that we want to use in the error messages - these are just what I came up with when doing a quick test.
After:
key_without_value:

key_with_value

key_with_closure

key_with_model

key_with_collection
