[12.x] - Redis - Establish connection first, before set the options

[alexmontoanelli]

Hi,

PhpRedisConnector try to set 4 options (max_retries,backoff_algorithm,backoff_base,backoff_cap) before
the connection has been established, and so, the options has no effect at all.

With a single line move, creating the connection/client before, the options then is set successfully on client.

[taylorotwell]

Don't these values specifically control the amount of retries when connecting though?

[alexmontoanelli]

These values are passed to client, in this case \Redis, to controll retries and backoff strategies.

If you set in your database.conf this settings (max_retries, backoff_algorithm), and then run
this code, you get the default values.

` php
$connection = Redis::connection();
$option1 = $connection->client()->getOption(\Redis::OPT_MAX_RETRIES);
$option2 = $connection->client()->getOption(\Redis::OPT_BACKOFF_ALGORITHM);
dump($option1, $option2);

`

//database settings

//code to get driver settings

//return values, before and after the fix
//10,0 (default options for max retries, and backoff), event (with database configure)
//30, 2 (respecting the config file)

[PavelKhatsimtsau]

Don't these values specifically control the amount of retries when connecting though?

Hey. Thanks everyone for the provided fix. We have faced with the same type of problem.
I would like to comment out a little bit regarding actual reason causing described above behavior - hopefully it might be useful in the future.
Previous version of the PhpRedisConnector will work fine in terms of any versions of phpredis extension equal or above 6.0 - as starting from that particular version documentation link - it is possible to use connection related parameters (including controls ones - as retry_interval, max_retry_limit and so on) in the Redis client constructor directly - eventually specified configuration parameters will be lazily applied.

Any version below 6.0 requires to establish preliminary connection to the redis server - and once it is connected successfully - we can send configuration commands to alter its behavior.

Thanks!