[12.x] Fix translation FileLoader overrides with a missing key #55342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the translations FileLoader behaviour when multiple overrides are set up and the last one is missing a translation key:
as in Fileloader → loadNamespaceOverrides() the
$lines
variable is passed to the function throughuse
, its value is used every time inarray_replace_recursive()
, instead of using the updated$output
variable coming from previous iterations of the reduce functionthis will cause the last iteration to remove all overrides made in previous ones
I added a failing test for this issue and implemented the fix: