-
Notifications
You must be signed in to change notification settings - Fork 11.4k
[11.x] Fix Illuminate\Support\EncodedHtmlString
from causing breaking change
#55149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Sebastian Hädrich <11225821+shaedrich@users.noreply.github.com>
No malicious content could be injected in the header, subcopy, etc. that were changed to use |
Typically the value will come from separate view such as:
|
@crynobone from 11.44.3, my emails now show up in plain html code. Reverting to 11.44.2 fixes it. Any ideas of what needs to be done? Thanks! |
Did you export email templates? If you do it best to check all |
Yes, but I only needed |
@crynobone We also had to revert back to 11.44.2 to fix the issue with plain html showing up in the MailMessage. Our notifications are using the toMail and returning a basic MailMessage and we aren't even using Markdown options. We did not publish/change the template files. Even the default footer is show html. Any ideas? |
I did to, but i also use some component with html in it, which only show up as escaped html. until now i was including them like
UPDATE: ok, i just missed to change some |
With this change, slot value should be considered as safe since it will contains HTML. Only content of mailable template should be encoded when using
{{ }}