Skip to content

Revert "[12.x] use "class-string" type for using pivot model" #55079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "[12.x] use "class-string" type for using pivot model" #55079

wants to merge 1 commit into from

Conversation

crynobone
Copy link
Member

Reverts #55053

fixes #55078

@crynobone crynobone marked this pull request as ready for review March 19, 2025 09:02
@AJenbo
Copy link
Contributor

AJenbo commented Mar 19, 2025

The problem here is actually Larastan which has an outdated stub: https://github.com/larastan/larastan/blob/3.x/stubs/common/BelongsToMany.stub

@crynobone
Copy link
Member Author

crynobone commented Mar 19, 2025 •
edited
Loading

Larastan 3 support Laravel 11 and 12. Wouldn't updating the stub cause more problem for older version?

@AJenbo
Copy link
Contributor

AJenbo commented Mar 19, 2025 •
edited
Loading

It should be fine with a default, I opened a PR to correct it: larastan/larastan#2231

Testing with this resolved all issues for my projects.

@calebdw is also working to smooth things over a bit in the framework.

@taylorotwell taylorotwell marked this pull request as draft March 19, 2025 14:12
@devfrey
Copy link
Contributor

devfrey commented Mar 19, 2025

The problem here is actually Larastan which has an outdated stub: larastan/larastan@3.x/stubs/common/BelongsToMany.stub

This has nothing to do with Larastan.

@calebdw
Copy link
Contributor

calebdw commented Mar 19, 2025

@crynobone, I already have a fix, this PR can be closed

#55086

@calebdw
Copy link
Contributor

calebdw commented Mar 19, 2025

Larastan 3 support Laravel 11 and 12. Wouldn't updating the stub cause more problem for older version?

No, Larastan can have version specific stubs

@taylorotwell taylorotwell deleted the revert-55053-AB-belongs-to-many-class-string branch March 19, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken BelongsToMany type definitions
5 participants
@crynobone @AJenbo @devfrey @calebdw @taylorotwell