[12.x] Reset PHP’s peak memory usage when resetting scope for queue worker #55069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to the reset of the total query duration that is already happening. PHP’s peak memory usage is another bit of global state is not useful to keep in a long-running process handling individual self-contained jobs. By resetting the peak memory usage for each executed job it becomes possible to measure a given job’s maximum memory usage accurately, allowing to optimize hardware resources, for example by placing individual jobs with a high-memory usage into their own queue that is executed on a larger worker instance.
TimWolla
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to the reset of the total query duration that is already happening. PHP’s peak memory usage is another bit of global state is not useful to keep in a long-running process handling individual self-contained jobs.
By resetting the peak memory usage for each executed job it becomes possible to measure a given job’s maximum memory usage accurately, allowing to optimize hardware resources, for example by placing individual jobs with a high-memory usage into their own queue that is executed on a larger worker instance.