Skip to content

[12.x] improved readability for aliasedPivotColumns #55055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

[12.x] improved readability for aliasedPivotColumns #55055

merged 1 commit into from
Mar 17, 2025

Conversation

browner12
Copy link
Contributor

  • use a new line for all chained Collection methods. easier to grok and much better diffs
  • use short closure for simple map call
  • utilize array unpacking to instantiate the Collection and avoid temporary variables

@browner12
improved readability for aliasedPivotColumns
a3a7287 
- use a new line for all chained Collection methods. easier to grok and much better diffs
- use short closure for simple `map` call
- utilize array unpacking to instantiate the Collection and avoid temporary variables
@taylorotwell taylorotwell merged commit c86bb43 into laravel:12.x Mar 17, 2025
41 checks passed
@browner12 browner12 deleted the AB-aliased-pivot-columns-readability branch March 17, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@browner12 @taylorotwell