[12.x] Add comprehensive test coverage for LazyCollection diff methods #55032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds test coverage for two LazyCollection methods: - diff: Tests comparing collections and returning elements not present in the given array - diffUsing: Tests comparing collections with custom comparison logic including case-insensitive string comparison and numeric division-based comparison
mohammadrasoulasghari
force-pushed
the
tests/lazy-collection-test-coverage
branch
from
9a0792b to
6905e9b
Compare
This commit adds thorough tests for three key diff methods in the LazyCollection class: 1. testDiffAssoc: Tests the diffAssoc method which returns items that exist in the original collection but not in the given collection, comparing both keys and values. 2. testDiffKeys: Tests the diffKeys method which returns items from the original collection whose keys don't exist in the given collection. 3. testDiffKeysUsing: Tests the diffKeysUsing method with a custom comparison callback that groups keys by hundreds, demonstrating how to implement custom key comparison logic. These tests ensure proper functionality of collection difference operations and verify that each method returns a new LazyCollection instance.
mohammadrasoulasghari
force-pushed
the
tests/lazy-collection-test-coverage
branch
from
6905e9b to
2b02414
Compare
|
I would really like to know the reason why this PR was closed so I can consider it next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive test coverage for LazyCollection comparison methods
In this PR, I've added thorough test coverage for several LazyCollection comparison methods that previously lacked tests to verify their behavior across different scenarios. 🧪
Methods covered in this PR:
Test scenarios included:
These tests ensure that the comparison methods work correctly under various conditions and handle all scenarios according to their intended functionality, providing greater confidence in the LazyCollection implementation's correctness and reliability.
Related work
This PR builds upon my previous contribution where I added tests for other LazyCollection methods (collapseWithKeys, containsOneItem, doesntContain, dot, hasAny). Together, these PRs significantly improve the test coverage of the LazyCollection class, helping maintain code quality and prevent regressions. 🚀