[12.x] apply final Pint fixes #55014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these changes apply the final Pint changes to make it pass. the majority of them are "braces_position" rule changes.
|
@browner12 As I mentioned before, Pint PR that failed StyleCI will get reverted 3ba180a |
|
how are we going to address the StyleCI failures here? we're in a little bit of a chicken/egg situation due to StyleCIs rules, which seems to have some inconsistencies on if it wants opening braces for an anonymous class on a newline or the same line. |
|
@crynobone yah, I was aware. didn't think Taylor would merge so quick before we had the chance to address it. |
|
I told you way before StyleCI failure doesn't prevent PR from to be merged since StyleCI would fix any invalid format. What's in the framework should have been the accepted format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these changes apply the final Pint changes to make it pass. the majority of them are "braces_position" rule changes.
this PR is being added because #54997 was closed.