[12.x] Add test coverage for Str::replaceMatches method #54930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds tests for the basic functionality of the replaceMatches method using string replacements and array of patterns.
This commit finalizes the test coverage for the replaceMatches method by adding tests for the limit parameter, which controls the maximum number of replacements to be performed.
mohammadrasoulasghari
force-pushed
the
feat/tests-for-str-replace-matches
branch
from
89f47b6 to
ec19d6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test coverage for Str::replaceMatches method ✨
This PR adds comprehensive test coverage for the Str::replaceMatches method to ensure it correctly handles string replacements, array patterns, callback functions, and limit parameters.
The test cases cover three main aspects of the method's functionality:
Basic string replacement ✅
Array-based pattern replacement
Callback-based replacement
Limit parameter functionality
The implementation follows the established testing patterns in the Laravel codebase, making it consistent with the existing test suite. I discovered while reviewing the code that the Str::replaceMatches method lacked any test coverage.🔍