Skip to content

[11.x] Fix Application::interBasePath() fails to resolve application when project name is "vendor" #54871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2025
Merged

[11.x] Fix Application::interBasePath() fails to resolve application when project name is "vendor" #54871

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a473b87
Fix `Application::interBasePath()` fails to resolve application when
crynobone Mar 3, 2025
e252f4d
wip
crynobone Mar 3, 2025
c2a24d3
wip
crynobone Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Illuminate/Foundation/Application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ public static function inferBasePath()
isset($_ENV['APP_BASE_PATH']) => $_ENV['APP_BASE_PATH'],
default => dirname(array_values(array_filter(
array_keys(ClassLoader::getRegisteredLoaders()),
fn ($path) => ! str_contains($path, '/vendor/'),
fn ($path) => ! str_starts_with($path, 'phar://'),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking for phar:// would solve the original bug #54118 and still allows vendor

))[0]),
};
}
Expand Down
Loading