Skip to content

[11.x] Add missing test for implode() #54704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2025
Merged

[11.x] Add missing test for implode() #54704

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
432383d
test current implode behavior for collections with models
nuernbergerA Feb 19, 2025
8e1c954
Merge branch '11.x' into ensure-implode-works
nuernbergerA Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tests/Support/SupportCollectionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
use Exception;
use Illuminate\Contracts\Support\Arrayable;
use Illuminate\Contracts\Support\Jsonable;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Collection;
use Illuminate\Support\HtmlString;
use Illuminate\Support\ItemNotFoundException;
Expand Down Expand Up @@ -2331,6 +2332,19 @@ public function testImplode($collection)
$this->assertSame('taylor-foo,dayle-bar', $data->implode(fn ($user) => $user['name'].'-'.$user['email'], ','));
}

#[DataProvider('collectionClassProvider')]
public function testImplodeModels($collection)
{
$model = new class extends Model {};
$model->setAttribute('email', 'foo');
$modelTwo = new class extends Model {};
$modelTwo->setAttribute('email', 'bar');
$data = new $collection([$model, $modelTwo]);

$this->assertSame('foobar', $data->implode('email'));
$this->assertSame('foo,bar', $data->implode('email', ','));
}

#[DataProvider('collectionClassProvider')]
public function testTake($collection)
{
Expand Down
Loading