Skip to content

Fix Collection::implode with \Stringable objects #54630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 17, 2025
Merged

Fix Collection::implode with \Stringable objects #54630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2b07417
Fix Collection::implode with \Stringable objects
timkelty Feb 15, 2025
5e9d49f
Use ByteString to match test against \Stringable
timkelty Feb 15, 2025
2fc464d
Don't mess with existing assertion
timkelty Feb 15, 2025
cd8b074
Add a new test instead of tweaking existing
timkelty Feb 15, 2025
73b7b00
WS
timkelty Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Illuminate/Collections/Collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ public function implode($value, $glue = null)

$first = $this->first();

if (is_array($first) || (is_object($first) && ! $first instanceof Stringable)) {
if (is_array($first) || (is_object($first) && ! $first instanceof \Stringable)) {
return implode($glue ?? '', $this->pluck($value)->all());
}

Expand Down
8 changes: 8 additions & 0 deletions tests/Support/SupportCollectionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
use PHPUnit\Framework\TestCase;
use ReflectionClass;
use stdClass;
use Symfony\Component\String\ByteString;
use Symfony\Component\VarDumper\VarDumper;
use Traversable;
use UnexpectedValueException;
Expand Down Expand Up @@ -2331,6 +2332,13 @@ public function testImplode($collection)
$this->assertSame('taylor-foo,dayle-bar', $data->implode(fn ($user) => $user['name'].'-'.$user['email'], ','));
}

#[DataProvider('collectionClassProvider')]
public function testImplodeStringable($collection)
{
$data = new $collection([new ByteString('taylor'), new ByteString('dayle')]);
$this->assertSame('taylordayle', $data->implode(''));
}

#[DataProvider('collectionClassProvider')]
public function testTake($collection)
{
Expand Down
Loading