Skip to content

[11.x] doesntContain on eloquent collection #54567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

[11.x] doesntContain on eloquent collection #54567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/Illuminate/Database/Eloquent/Collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,19 @@ public function contains($key, $operator = null, $value = null)
return parent::contains(fn ($model) => $model->getKey() == $key);
}

/**
* Determine if a key does not exist in the collection.
*
* @param (callable(TModel, TKey): bool)|TModel|string|int $key
* @param mixed $operator
* @param mixed $value
* @return bool
*/
public function doesntContain($key, $operator = null, $value = null)
{
return ! $this->contains(...func_get_args());
}

/**
* Get the array of primary keys.
*
Expand Down
26 changes: 26 additions & 0 deletions tests/Database/DatabaseEloquentCollectionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ public function testContainsWithMultipleArguments()
$this->assertTrue($c->contains('id', 1));
$this->assertTrue($c->contains('id', '>=', 2));
$this->assertFalse($c->contains('id', '>', 2));

$this->assertFalse($c->doesntContain('id', 1));
$this->assertFalse($c->doesntContain('id', '>=', 2));
$this->assertTrue($c->doesntContain('id', '>', 2));
}

public function testContainsIndicatesIfModelInArray()
Expand All @@ -108,6 +112,10 @@ public function testContainsIndicatesIfModelInArray()
$this->assertTrue($c->contains($mockModel));
$this->assertTrue($c->contains($mockModel2));
$this->assertFalse($c->contains($mockModel3));

$this->assertFalse($c->doesntContain($mockModel));
$this->assertFalse($c->doesntContain($mockModel2));
$this->assertTrue($c->doesntContain($mockModel3));
}

public function testContainsIndicatesIfDifferentModelInArray()
Expand All @@ -122,6 +130,9 @@ public function testContainsIndicatesIfDifferentModelInArray()

$this->assertTrue($c->contains($mockModelFoo));
$this->assertFalse($c->contains($mockModelBar));

$this->assertFalse($c->doesntContain($mockModelFoo));
$this->assertTrue($c->doesntContain($mockModelBar));
}

public function testContainsIndicatesIfKeyedModelInArray()
Expand All @@ -136,6 +147,10 @@ public function testContainsIndicatesIfKeyedModelInArray()
$this->assertTrue($c->contains(1));
$this->assertTrue($c->contains(2));
$this->assertFalse($c->contains(3));

$this->assertFalse($c->doesntContain(1));
$this->assertFalse($c->doesntContain(2));
$this->assertTrue($c->doesntContain(3));
}

public function testContainsKeyAndValueIndicatesIfModelInArray()
Expand All @@ -151,6 +166,10 @@ public function testContainsKeyAndValueIndicatesIfModelInArray()
$this->assertTrue($c->contains('name', 'Taylor'));
$this->assertTrue($c->contains('name', 'Abigail'));
$this->assertFalse($c->contains('name', 'Dayle'));

$this->assertFalse($c->doesntContain('name', 'Taylor'));
$this->assertFalse($c->doesntContain('name', 'Abigail'));
$this->assertTrue($c->doesntContain('name', 'Dayle'));
}

public function testContainsClosureIndicatesIfModelInArray()
Expand All @@ -167,6 +186,13 @@ public function testContainsClosureIndicatesIfModelInArray()
$this->assertFalse($c->contains(function ($model) {
return $model->getKey() > 2;
}));

$this->assertFalse($c->doesntContain(function ($model) {
return $model->getKey() < 2;
}));
$this->assertTrue($c->doesntContain(function ($model) {
return $model->getKey() > 2;
}));
}

public function testFindMethodFindsModelById()
Expand Down