Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.x] Support for Attaching Databases as Schemas in SQLite #54380

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add tests
  • Loading branch information
hafezdivandari committed Jan 27, 2025
commit 247a74da4270c8817e1f53dab242dfdf907fcb78
12 changes: 0 additions & 12 deletions tests/Integration/Database/SchemaBuilderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -792,18 +792,6 @@ public function testAddAndDropPrimaryOnSqlite()
$this->assertTrue(Schema::hasIndex('posts', ['user_name'], 'unique'));
}

#[RequiresDatabase('sqlite')]
public function testSetJournalModeOnSqlite()
{
file_put_contents(DB::connection('sqlite')->getConfig('database'), '');

$this->assertSame('delete', DB::connection('sqlite')->select('PRAGMA journal_mode')[0]->journal_mode);

Schema::connection('sqlite')->setJournalMode('WAL');

$this->assertSame('wal', DB::connection('sqlite')->select('PRAGMA journal_mode')[0]->journal_mode);
}

public function testAddingMacros()
{
Schema::macro('foo', fn () => 'foo');
Expand Down
90 changes: 90 additions & 0 deletions tests/Integration/Database/Sqlite/ConnectorTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,90 @@
<?php

namespace Illuminate\Tests\Integration\Database\Sqlite;

use Illuminate\Support\Arr;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Schema;
use Illuminate\Tests\Integration\Database\DatabaseTestCase;
use Orchestra\Testbench\Attributes\RequiresDatabase;

#[RequiresDatabase('sqlite')]
class ConnectorTest extends DatabaseTestCase
{
private string $databasePath;

protected function defineDatabaseMigrations()
{
Schema::createDatabase($this->databasePath = database_path('secondary.sqlite'));
}

protected function destroyDatabaseMigrations()
{
Schema::dropDatabaseIfExists($this->databasePath);
}

public function testConnectionConfigurations()
{
$schema = DB::build([
'driver' => 'sqlite',
'database' => ':memory:',
])->getSchemaBuilder();

$this->assertSame(0, $schema->pragma('foreign_keys'));
$this->assertSame(60000, $schema->pragma('busy_timeout'));
$this->assertSame('memory', $schema->pragma('journal_mode'));
$this->assertSame(2, $schema->pragma('synchronous'));

$schema = DB::build([
'driver' => 'sqlite',
'database' => $this->databasePath,
'foreign_key_constraints' => true,
'busy_timeout' => 12345,
'journal_mode' => 'wal',
'synchronous' => 'normal',
])->getSchemaBuilder();

$this->assertSame(1, $schema->pragma('foreign_keys'));
$this->assertSame(12345, $schema->pragma('busy_timeout'));
$this->assertSame('wal', $schema->pragma('journal_mode'));
$this->assertSame(1, $schema->pragma('synchronous'));

$schema->pragma('foreign_keys', 0);
$schema->pragma('busy_timeout', 54321);
$schema->pragma('journal_mode', 'delete');
$schema->pragma('synchronous', 0);

$this->assertSame(0, $schema->pragma('foreign_keys'));
$this->assertSame(54321, $schema->pragma('busy_timeout'));
$this->assertSame('delete', $schema->pragma('journal_mode'));
$this->assertSame(0, $schema->pragma('synchronous'));
}

public function testAttachingDatabases()
{
$connection = DB::build([
'driver' => 'sqlite',
'database' => ':memory:',
'schemas' => [
'secondary' => $this->databasePath,
'tertiary' => ':memory:',
],
]);

$this->assertSame(['main', 'secondary', 'tertiary'], $connection->getSchemaBuilder()->getCurrentSchemaListing());
$this->assertEquals([
'main' => null,
'secondary' => $this->databasePath,
'tertiary' => null,
], Arr::pluck($connection->getSchemaBuilder()->getSchemas(), 'path', 'name'));

$connection->reconnect();

$this->assertSame(['main', 'secondary', 'tertiary'], $connection->getSchemaBuilder()->getCurrentSchemaListing());
$this->assertEquals([
'main' => null,
'secondary' => $this->databasePath,
'tertiary' => null,
], Arr::pluck($connection->getSchemaBuilder()->getSchemas(), 'path', 'name'));
}
}