[11.x] fix: Forcing DB Cache driver to always use the Write connection #54284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Cache with a "database" driver that uses a read/write config, it will use the "read" connection
unless DB_CACHE_CONNECTION=mysql::write is used.
If the read database is lagging behind the write database, it can cause issues, especially for locks.
To test it we can use the following:
```php
// .env
CACHE_STORE=database
// routes/web.php
Route::get('/test-cache-connection', function () {
\Illuminate\Support\Facades\Cache::has('some-key');
});
// config/database.php
'mysql' => [
'read' => [
'host' => [
// If you see this error means it's using the "read" connection.
// Invalid Host. Fails with: SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo for some.invalid.host.invalid failed...
'some.invalid.host.invalid',
],
],
'write' => [
'host' => [
// Valid Host
'127.0.0.1',
],
],
// 'host' => env('DB_HOST', '127.0.0.1'),
// ...
```
When using Cache with a "database" driver that uses a read/write config, it will use the "read" connection
unless `DB_CACHE_CONNECTION=mysql::write` is used.
If the read database is lagging behind the write database, it can cause issues, especially for locks.
To test it we can use the following:
```php
// .env
CACHE_STORE=database
// routes/web.php
Route::get('/test-cache-connection', function () {
\Illuminate\Support\Facades\Cache::has('some-key');
});
// config/database.php
'mysql' => [
'read' => [
'host' => [
// If you see this error means it's using the "read" connection.
// Invalid Host. Fails with: SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo for some.invalid.host.invalid failed...
'some.invalid.host.invalid',
],
],
'write' => [
'host' => [
// Valid Host
'127.0.0.1',
],
],
// 'host' => env('DB_HOST', '127.0.0.1'),
// ...
```
…connection' into fix-database-cache-driver-write-connection # Conflicts: # src/Illuminate/Cache/DatabaseStore.php
|
Hmm, I dunno about this one. It actually does seem useful to use read replicas in front of a database powered cache? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #54231
When using Cache with a "database" driver that uses a read/write config, it will use the "read" connection unless
DB_CACHE_CONNECTION=mysql::writeis used.If the read database is lagging behind the write database, it can cause issues, especially for locks.
To test it we can use the following: