Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.x] use promoted properties for Routing events #53854

Merged
merged 1 commit into from
Dec 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 6 additions & 20 deletions src/Illuminate/Routing/Events/PreparingResponse.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,30 +4,16 @@

class PreparingResponse
{
/**
* The request instance.
*
* @var \Symfony\Component\HttpFoundation\Request
*/
public $request;

/**
* The response instance.
*
* @var mixed
*/
public $response;

/**
* Create a new event instance.
*
* @param \Symfony\Component\HttpFoundation\Request $request
* @param mixed $response
* @param \Symfony\Component\HttpFoundation\Request $request The request instance.
* @param mixed $response The response instance.
* @return void
*/
public function __construct($request, $response)
{
$this->request = $request;
$this->response = $response;
public function __construct(
public $request,
public $response,
) {
}
}
26 changes: 6 additions & 20 deletions src/Illuminate/Routing/Events/ResponsePrepared.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,30 +4,16 @@

class ResponsePrepared
{
/**
* The request instance.
*
* @var \Symfony\Component\HttpFoundation\Request
*/
public $request;

/**
* The response instance.
*
* @var \Symfony\Component\HttpFoundation\Response
*/
public $response;

/**
* Create a new event instance.
*
* @param \Symfony\Component\HttpFoundation\Request $request
* @param \Symfony\Component\HttpFoundation\Response $response
* @param \Symfony\Component\HttpFoundation\Request $request The request instance.
* @param \Symfony\Component\HttpFoundation\Response $response The response instance.
* @return void
*/
public function __construct($request, $response)
{
$this->request = $request;
$this->response = $response;
public function __construct(
public $request,
public $response,
) {
}
}
26 changes: 6 additions & 20 deletions src/Illuminate/Routing/Events/RouteMatched.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,30 +4,16 @@

class RouteMatched
{
/**
* The route instance.
*
* @var \Illuminate\Routing\Route
*/
public $route;

/**
* The request instance.
*
* @var \Illuminate\Http\Request
*/
public $request;

/**
* Create a new event instance.
*
* @param \Illuminate\Routing\Route $route
* @param \Illuminate\Http\Request $request
* @param \Illuminate\Routing\Route $route The route instance.
* @param \Illuminate\Http\Request $request The request instance.
* @return void
*/
public function __construct($route, $request)
{
$this->route = $route;
$this->request = $request;
public function __construct(
public $route,
public $request,
) {
}
}
15 changes: 4 additions & 11 deletions src/Illuminate/Routing/Events/Routing.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,14 @@

class Routing
{
/**
* The request instance.
*
* @var \Illuminate\Http\Request
*/
public $request;

/**
* Create a new event instance.
*
* @param \Illuminate\Http\Request $request
* @param \Illuminate\Http\Request $request The request instance.
* @return void
*/
public function __construct($request)
{
$this->request = $request;
public function __construct(
public $request,
) {
}
}
Loading