[11.x] Do not overwrite existing link header(s) in AddLinkHeadersForPreloadedAssets middleware
#53463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnoordsij
changed the title
AddLinkHeadersForPreloadedAssetsAddLinkHeadersForPreloadedAssets middleware
timacdonald
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking into adding some manual
Linkheaders for some static assets, I noticed I could not manage to add any when theAddLinkHeadersForPreloadedAssetsis active. This PR alters the behavior to not overwrite theLinkheader, but rather add to it. This ensures developers have the opportunity to also addLinkheaders of their own within the scope of their application logic.I also reversed an expected vs. actual ordering in an existing test.