[11.x] Fix dropColumnIfExists and dropForeignIfExists
#53337
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does:
dropColumnsIfExists,dropColumnIfExistsanddropForeignIfExists#53305:SchemaFacade onBlueprint, as it ignores builder / migration's connection, checking existence on default connection and dropping on the specified connection.if existsstatement on PostgreSQL.dropForeignIfExists(), could never find the constraint name and was doing nothing!vectorColumn Type #53316dimensionis explicitlynull.PS:
Blueprintdoesn't know about the DB connection, it just keeps commands and whenBuilderprovides the connection and grammar instances,Blueprintconverts them to SQL statements (defined onSchema\Grammar).