[11.x] Pick up existing views and markdowns when creating mails #53308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would just return an error message that the file already exists. |
|
@taylorotwell No problem, I have updated according to your comment. |
|
@taylorotwell thanks boss! We plan to refactor our emails to mailables using existing blade files. This will make our lives way easier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spend a whole afternoon designing an email template named
resources/views/customers/welcome.blade.php.Then I run the command
php artisan make:mail --view=customers.welcome.And my completed template has been replaced with the stub file.
This is not exactly ideal, and it is easy to fix. People might have existing templates to use, or design them first. If blade files are already present, it would be great if they are picked up.
To be consistent, I do the same with markdowns.