Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Fixes regression with queue:work Command #53076

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

crynobone
Copy link
Member

@crynobone crynobone commented Oct 9, 2024

hasOption() will always return true if it is define, this cause Laravel Framework 11.27.1 installation to always output using json.

v11.27.0

CleanShot 2024-10-09 at 12 07 03

v11.27.1

CleanShot 2024-10-09 at 12 07 27

option exists in the definition

`hasOption()` will always return true if it is define, this cause
Laravel Framework 11.27.1 installation to always output using json.

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone marked this pull request as ready for review October 9, 2024 03:54
@crynobone crynobone changed the title [11.x] Fixes regression when using Command::hasOption('json') when the option exists in the definition [11.x] Fixes regression with queue:work Command Oct 9, 2024
@crynobone crynobone merged commit a143a77 into 11.x Oct 9, 2024
33 of 34 checks passed
@crynobone crynobone deleted the regression-53072 branch October 9, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant