[11.x] Fix PHPDoc for TestResponse's Response Type to \Symfony\Component\HttpFoundation\Response
#52915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayw-geek
changed the title
Response Type to \Symfony\Component\HttpFoundation\ResponseResponse Type to \Symfony\Component\HttpFoundation\Response
crynobone
reviewed
Sep 25, 2024
kayw-geek
force-pushed
the
bugfix/fix-incorrect-phpdoc-for-test-response
branch
2 times, most recently
from
c36c795
to
5e2c20e
Compare
crynobone
reviewed
Sep 25, 2024
kayw-geek
force-pushed
the
bugfix/fix-incorrect-phpdoc-for-test-response
branch
6 times, most recently
from
0e4d831
to
eb396d5
Compare
kayw-geek
force-pushed
the
bugfix/fix-incorrect-phpdoc-for-test-response
branch
from
eb396d5
to
dbcfffb
Compare
crynobone
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses an issue where the PHPDoc for
TestResponseincorrectly specifies theResponsetype as\Illuminate\Http\Response. Upon closer inspection, it was found that the actual response type can be more generalized to\Symfony\Component\HttpFoundation\Response. Specifically, when dealing with download responses or redirect responses, the type is not\Illuminate\Http\Response.