Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Fix for not automatically registering commands in App\Console\Commands #52903

Merged
merged 1 commit into from
Sep 25, 2024
Merged

[11.x] Fix for not automatically registering commands in App\Console\Commands #52903

merged 1 commit into from
Sep 25, 2024

Conversation

SamuelNitsche
Copy link
Contributor

@SamuelNitsche SamuelNitsche commented Sep 24, 2024 •
edited
Loading

PR #52867 introduced a Bug #52902 when registering commands using both the routes/console.php and app/Commands namespace.

This PR fixes the bug by simply merging the commands found.
Again, unfortunately no tests.

@rodrigopedra
Copy link
Contributor

Thanks!

Was about to send the same PR, just ended running the local tests =)

@rodrigopedra rodrigopedra mentioned this pull request Sep 24, 2024
Closed
@devajmeireles
Copy link
Contributor

@taylorotwell Could you please take a look into this? We need this as soon as possible. Without it, no custom commands can be executed, making it impossible to use the latest version.

@crynobone crynobone linked an issue Sep 25, 2024 that may be closed by this pull request
[11.x] After Laravel 11.24.0 commands in app/Console/Commands are not auto-registered #52902
Closed
@crynobone crynobone merged commit d76b2f1 into laravel:11.x Sep 25, 2024
33 checks passed
crynobone added a commit that referenced this pull request Sep 26, 2024
@crynobone
Revert "Fix for not automatically registering commands in App\Console…
e5b3239 
…\Commands (#52903)"

This reverts commit d76b2f1.
crynobone added a commit that referenced this pull request Sep 26, 2024
@crynobone
Revert "Fix for not automatically registering commands in App\Console…
dba7af0 
…\Commands (#52903)"

This reverts commit d76b2f1.
@crynobone crynobone mentioned this pull request Sep 26, 2024
Merged
crynobone added a commit that referenced this pull request Sep 26, 2024
@crynobone
[11.x] Revert auto-discovering routes/console.php as this will caus…
1c955a6 
…e breaking change with the default `withRouting($console)` (#52939)

* Revert "Fix for not automatically registering commands in App\Console\Commands (#52903)"

This reverts commit d76b2f1.

* Revert "Auto-Register Commands in `routes/console.php` (#52867)"

This reverts commit e216708.
@crynobone crynobone mentioned this pull request Sep 26, 2024
Merged
taylorotwell pushed a commit that referenced this pull request Sep 26, 2024
@crynobone
[11.x] Revert auto-discovering routes/console.php as this will caus…
170adae 
…e breaking change with the default `withRouting($console)` (#52942)

* Revert "Fix for not automatically registering commands in App\Console\Commands (#52903)"

This reverts commit d76b2f1.

* Revert "Auto-Register Commands in `routes/console.php` (#52867)"

This reverts commit e216708.
@crynobone
Copy link
Member

@SamuelNitsche this PR has been reverted due to breaking change with existing application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[11.x] After Laravel 11.24.0 commands in app/Console/Commands are not auto-registered
4 participants
@SamuelNitsche @rodrigopedra @devajmeireles @crynobone