Skip to content

[11.x] feat: improve Collection groupBy, keyBy generics #52787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2024
Merged

[11.x] feat: improve Collection groupBy, keyBy generics #52787

merged 1 commit into from
Sep 16, 2024

Conversation

@calebdw
Copy link
Contributor

@calebdw calebdw commented Sep 13, 2024

Hello!

This updates the Collection groupBy and keyBy generics to more accurately detect what the key types of the resultant collections should be.

Thanks!

@calebdw calebdw changed the title [11.x] feat: improve groupBy, keyBy generics [11.x] feat: improve Collection groupBy, keyBy generics Sep 13, 2024
@taylorotwell taylorotwell merged commit 4b47b4e into laravel:11.x Sep 16, 2024
@calebdw
Copy link
Contributor Author

calebdw commented Sep 16, 2024

Thank you sir!

@calebdw calebdw deleted the group_key_by branch September 16, 2024 14:33
@kayw-geek kayw-geek mentioned this pull request Sep 25, 2024
Merged
@calebdw calebdw mentioned this pull request Sep 25, 2024
Closed
@renovate renovate bot mentioned this pull request Oct 16, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@calebdw @taylorotwell