[11.x] Add php doc for ServiceProvider bindings and singletons properties #52298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devfrey
reviewed
Jul 29, 2024
Comment on lines
+14
to
+15
| * @property array<class-string, class-string> $bindings All of the container bindings that should be registered. | ||
| * @property array<class-string, class-string> $singletons All of the singletons that should be registered. |
There was a problem hiding this comment.
These types are wrong, because bindings (and singletons) don't need to be class strings. They should be typehinted as string instead.
There was a problem hiding this comment.
I also suggest singletons' key to be array-key type, since integer is allowed:
framework/src/Illuminate/Foundation/Application.php
Lines 880 to 884 in c2eb318
There was a problem hiding this comment.
Feel free to send in follow up PR's 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#52256 with no breaking change