[12.x] mergeIfMissing allows merging with nested arrays #52242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR updates the
mergeIfMissing
method from the Http/Request class to allow merging with nested arrays using the "." (dot) notation.The section named "Actual Behaviour" marks Laravel's current implementation output for the described scenario, while the "Expected Behaviour" shows the output if using my changes to the Http/Request class.
I've added 2 assertions to the
testMergeIfMissingMethod
test.Problem / Setting up the scenario:
and tried merging the input in my controller with:
Expected Behaviour
expecting to set the current request input to:
Actual Behaviour
but instead I was getting: