Skip to content

[11.x] Fix return for ApplicationBuilder:: withCommandRouting method #52181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2024
Merged

[11.x] Fix return for ApplicationBuilder:: withCommandRouting method #52181

merged 1 commit into from
Jul 18, 2024

Conversation

@seriquynh
Copy link
Contributor

@seriquynh seriquynh commented Jul 18, 2024 •
edited
Loading

The ApplicationBuilder::withCommandRouting method is missing return statement, so I added for it.

@seriquynh seriquynh changed the title [11.x] Fix return for ApplicationBuilder::withBindings method [11.x] Fix return for ApplicationBuilder:: withCommandRouting method Jul 18, 2024
@taylorotwell taylorotwell merged commit 202bdc4 into laravel:11.x Jul 18, 2024
@seriquynh seriquynh deleted the fix-return branch July 18, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rodrigopedra rodrigopedra rodrigopedra left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@seriquynh @rodrigopedra @taylorotwell