Skip to content

Conversation

@sethsandaru
Copy link
Contributor

Hi guys,

As a person who really loves the php artisan serve and jumps into the development immediately, I'd like to add some improvements and hopefully, it would help other developers too

  1. Print out a better request time, for requests that take less than 1 second, ~0s doesn't seem so helpful at all.
  2. Show the request's route instead of "........."

Thanks all.

Before

before

After

after

@chu121su12
Copy link
Contributor

Any chance displaying the request method and response status code?

@sethsandaru
Copy link
Contributor Author

Any chance displaying the request method and response status code?

that'd be something I'll try to improve next 😄

@seriquynh
Copy link
Contributor

Your improvement looks great. Hope it'll be accepted soon.

Copy link
Member

@nunomaduro nunomaduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes look generally fine to me; however, I've found this particular command's code a little bit problematic when we change code on it. So, we may have to revert this pull request if we find out that it causes problems.

@taylorotwell taylorotwell merged commit 4371762 into laravel:11.x Jul 1, 2024
@sethsandaru sethsandaru deleted the patch-serve-command-elevated branch July 2, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants