[11.x] Improve Queue::assertNothingPushed() error message #51814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewminion-luminfire
pushed a commit
to macbookandrew/framework
that referenced
this pull request
Jun 19, 2024
taylorotwell
pushed a commit
that referenced
this pull request
Jun 20, 2024
…spatched(), Mail::assertNothingSent(), Notification::assertNothingSent() error messages (#51846) * add class names to bus, mail, and notification assertNothing* methods Similar to #51814 for jobs * improve batched jobs * fix line endings for Windows * add similar handling for events * standardize output * add back auto-deleted type docs * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queue::assertNothingPushed()currently doesn't show a useful message when the assertion fails:This PR makes
Queue::assertNothingPushed()show the names of the jobs that were unexpectedly pushed: