[11.x] Optimize SetCacheHeaders to ensure error responses aren't cached #50903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinaWilliam
changed the title
|
Think this should just be the default behavior tbh. 👍 |
MinaWilliam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Currently, error responses can be cached by the
cache.headersmiddleware, leading to outdated errors for users.Solution:
This PR conditionally apply caching only when the response has a successful HTTP status code.
Changes:
SetCacheHeadersmiddleware to only cache if the response is successful.Backward Compatibility:
This change is fully backward-compatible.
Documentation:
The Laravel documentation will need to be updated to reflect the new directive.