Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Only stage committed transactions #49093

Merged
merged 19 commits into from
Nov 23, 2023
Merged

[10.x] Only stage committed transactions #49093

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
bc0d93a
Only stage committed transactions
hansnn Nov 22, 2023
6d269a2
Fix styleci
hansnn Nov 22, 2023
cd0212b
push failing test
taylorotwell Nov 22, 2023
fc1d611
fix failing test
taylorotwell Nov 22, 2023
105bf6e
add another failing test
taylorotwell Nov 22, 2023
dd4d140
rename test
taylorotwell Nov 22, 2023
c8d8f49
fix formatting
taylorotwell Nov 22, 2023
5d62e7f
add another test
taylorotwell Nov 22, 2023
fcf5ab6
rename test
taylorotwell Nov 22, 2023
4b01e70
rename test
taylorotwell Nov 22, 2023
fe87aa0
refactor to parents
taylorotwell Nov 22, 2023
bfbadd2
small fix
taylorotwell Nov 22, 2023
d94394a
check connection
taylorotwell Nov 22, 2023
feee508
key current transactions by connection
taylorotwell Nov 23, 2023
ec7a29b
another fix
taylorotwell Nov 23, 2023
5f9a972
call values
taylorotwell Nov 23, 2023
d04e88e
formatting
taylorotwell Nov 23, 2023
24c10de
add another test
taylorotwell Nov 23, 2023
89d496e
comment
taylorotwell Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename test
  • Loading branch information
@taylorotwell
taylorotwell committed Nov 22, 2023
commit dd4d14093eaae31909183e4406eb3c502d78d404
2 changes: 1 addition & 1 deletion tests/Integration/Events/ShouldDispatchAfterCommitEventTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ public function testItHandlesNestedTransactionsWhereTheSecondOneFails()
$this->assertFalse(AnotherShouldDispatchAfterCommitTestEvent::$ran);
}

public function testItHandlesDeeplyNestedTransactions()
public function testChildCallbacksShouldNotBeDispatchedIfTheirParentFails()
{
Event::listen(ShouldDispatchAfterCommitTestEvent::class, ShouldDispatchAfterCommitListener::class);

Expand Down
Loading