[10.x] Array cache unit-test #48591
Closed
[10.x] Array cache unit-test #48591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Will let @timacdonald review this one. |
|
@driesvints I was sitting and thinking about the while crutch and remembered setTestNow. Added a commit to PR pipeline is green: https://github.com/rez1dent3/laraframework/pull/2 |
|
I'm closing this one in favour of #48573. The unit test here doesn't test the boundary enough to very all the current problems with the expiry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I suggest adding only a unit test to avoid unpleasant bugs in the future: #48569
And move this PR #48582 to laravel 11 or close it altogether.
@driesvints FYI