[11.x] Prevent attributes cast to an enum from being set to another enum #47465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
requested changes
Jun 16, 2023
|
Hmm... I'm not sure why this is getting errors in CI. It's generating the error and passing locally. This line should be catching the invalid string and throwing a |
PHLAK
changed the title
|
I've updated the PR to merge to |
driesvints
requested review from
taylorotwell
and removed request for
driesvints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent an attribute that is cast to an enum from being set to another enum value or a value not defined as a case on a
BackedEnum. This will throw aValueErrorlike the following when attempting to do so.NOTE: This is technically a breaking change but I'd consider it more of a bug fix so handle that as you will.
Resolves #47454