[10.x] Remove redundant 'setAccessible' methods

src/Illuminate/Console/Scheduling/ScheduleListCommand.php

@@ -196,9 +196,7 @@ private function formatCronExpression($expression, $spacing)
      */
     private function getClosureLocation(CallbackEvent $event)
     {
-        $callback = tap((new ReflectionClass($event))->getProperty('callback'))
-                        ->setAccessible(true)
-                        ->getValue($event);
+        $callback = (new ReflectionClass($event))->getProperty('callback')->getValue($event);
 
         if ($callback instanceof Closure) {
             $function = new ReflectionFunction($callback);

src/Illuminate/Console/View/Components/Component.php

@@ -108,8 +108,6 @@ protected function usingQuestionHelper($callable)
             ->getParentClass()
             ->getProperty('questionHelper');
 
-        $property->setAccessible(true);
-
         $currentHelper = $property->isInitialized($this->output)
             ? $property->getValue($this->output)
             : new SymfonyQuestionHelper();

src/Illuminate/Database/Eloquent/Builder.php

@@ -1976,8 +1976,6 @@ protected static function registerMixin($mixin, $replace)
 
         foreach ($methods as $method) {
             if ($replace || ! static::hasGlobalMacro($method->name)) {
-                $method->setAccessible(true);
-
                 static::macro($method->name, $method->invoke($mixin));
             }
         }

src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php

@@ -2227,8 +2227,6 @@ protected static function getAttributeMarkedMutatorMethods($class)
 
             if ($returnType instanceof ReflectionNamedType &&
                 $returnType->getName() === Attribute::class) {
-                $method->setAccessible(true);
-
                 if (is_callable($method->invoke($instance)->get)) {
                     return true;
                 }

src/Illuminate/Macroable/Traits/Macroable.php

@@ -45,7 +45,6 @@ public static function mixin($mixin, $replace = true)
 
         foreach ($methods as $method) {
             if ($replace || ! static::hasMacro($method->name)) {
-                $method->setAccessible(true);
                 static::macro($method->name, $method->invoke($mixin));
             }
         }

src/Illuminate/Queue/SerializesModels.php

@@ -27,8 +27,6 @@ public function __serialize()
                 continue;
             }
 
-            $property->setAccessible(true);
-
             if (! $property->isInitialized($this)) {
                 continue;
             }
@@ -82,8 +80,6 @@ public function __unserialize(array $values)
                 continue;
             }
 
-            $property->setAccessible(true);
-
             $property->setValue(
                 $this, $this->getRestoredPropertyValue($values[$name])
             );
@@ -98,8 +94,6 @@ public function __unserialize(array $values)
      */
     protected function getPropertyValue(ReflectionProperty $property)
     {
-        $property->setAccessible(true);
-
         return $property->getValue($this);
     }
 }

src/Illuminate/Testing/TestResponse.php

@@ -1657,8 +1657,6 @@ protected function appendMessageToException($message, $exception)
     {
         $property = new ReflectionProperty($exception, 'message');
 
-        $property->setAccessible(true);
-
         $property->setValue(
             $exception,
             $exception->getMessage().PHP_EOL.PHP_EOL.$message.PHP_EOL

tests/Cookie/CookieTest.php

@@ -217,7 +217,6 @@ public function getCreator()
     private function getQueuedPropertyValue(CookieJar $cookieJar)
     {
         $property = (new ReflectionObject($cookieJar))->getProperty('queued');
-        $property->setAccessible(true);
 
         return $property->getValue($cookieJar);
     }

tests/Database/DatabaseConnectionFactoryTest.php

@@ -90,9 +90,7 @@ public function testSingleConnectionNotCreatedUntilNeeded()
     {
         $connection = $this->db->getConnection();
         $pdo = new ReflectionProperty(get_class($connection), 'pdo');
-        $pdo->setAccessible(true);
         $readPdo = new ReflectionProperty(get_class($connection), 'readPdo');
-        $readPdo->setAccessible(true);
 
         $this->assertNotInstanceOf(PDO::class, $pdo->getValue($connection));
         $this->assertNotInstanceOf(PDO::class, $readPdo->getValue($connection));
@@ -102,9 +100,7 @@ public function testReadWriteConnectionsNotCreatedUntilNeeded()
     {
         $connection = $this->db->getConnection('read_write');
         $pdo = new ReflectionProperty(get_class($connection), 'pdo');
-        $pdo->setAccessible(true);
         $readPdo = new ReflectionProperty(get_class($connection), 'readPdo');
-        $readPdo->setAccessible(true);
 
         $this->assertNotInstanceOf(PDO::class, $pdo->getValue($connection));
         $this->assertNotInstanceOf(PDO::class, $readPdo->getValue($connection));

tests/Database/DatabaseConnectionTest.php

@@ -412,7 +412,6 @@ public function testOnLostConnectionPDOIsSwappedOutsideTransaction()
     public function testRunMethodRetriesOnFailure()
     {
         $method = (new ReflectionClass(Connection::class))->getMethod('run');
-        $method->setAccessible(true);
 
         $pdo = $this->createMock(DatabaseConnectionTestMockPDO::class);
         $mock = $this->getMockConnection(['tryAgainIfCausedByLostConnection'], $pdo);
@@ -429,7 +428,6 @@ public function testRunMethodNeverRetriesIfWithinTransaction()
         $this->expectExceptionMessage('(Connection: conn, SQL: ) (Connection: , SQL: )');
 
         $method = (new ReflectionClass(Connection::class))->getMethod('run');
-        $method->setAccessible(true);
 
         $pdo = $this->getMockBuilder(DatabaseConnectionTestMockPDO::class)->onlyMethods(['beginTransaction'])->getMock();
         $mock = $this->getMockConnection(['tryAgainIfCausedByLostConnection'], $pdo);

tests/Database/DatabaseEloquentFactoryTest.php

@@ -497,7 +497,6 @@ public function test_counted_sequence()
 
         $class = new ReflectionClass($factory);
         $prop = $class->getProperty('count');
-        $prop->setAccessible(true);
         $value = $prop->getValue($factory);
 
         $this->assertSame(3, $value);

tests/Database/DatabaseEloquentModelTest.php

@@ -1159,7 +1159,6 @@ public function testGetArrayableRelationsFunctionExcludeHiddenRelationships()
 
         $class = new ReflectionClass($model);
         $method = $class->getMethod('getArrayableRelations');
-        $method->setAccessible(true);
 
         $model->setRelation('foo', ['bar']);
         $model->setRelation('bam', ['boom']);

tests/Database/DatabaseMySqlSchemaStateTest.php

@@ -22,13 +22,13 @@ public function testConnectionString(string $expectedConnectionString, array $ex
 
         // test connectionString
         $method = new ReflectionMethod(get_class($schemaState), 'connectionString');
-        $connString = tap($method)->setAccessible(true)->invoke($schemaState);
+        $connString = $method->invoke($schemaState);
 
         self::assertEquals($expectedConnectionString, $connString);
 
         // test baseVariables
         $method = new ReflectionMethod(get_class($schemaState), 'baseVariables');
-        $variables = tap($method)->setAccessible(true)->invoke($schemaState, $dbConfig);
+        $variables = $method->invoke($schemaState, $dbConfig);
 
         self::assertEquals($expectedVariables, $variables);
     }

tests/Foundation/Bootstrap/HandleExceptionsTest.php

@@ -31,7 +31,7 @@ protected function setUp(): void
         $this->handleExceptions = new HandleExceptions();
 
         with(new ReflectionClass($this->handleExceptions), function ($reflection) {
-            $property = tap($reflection->getProperty('app'))->setAccessible(true);
+            $property = $reflection->getProperty('app');
 
             $property->setValue(
                 $this->handleExceptions,
@@ -324,7 +324,7 @@ public function testIgnoreDeprecationIfLoggerUnresolvable()
     public function testForgetApp()
     {
         $appResolver = fn () => with(new ReflectionClass($this->handleExceptions), function ($reflection) {
-            $property = tap($reflection->getProperty('app'))->setAccessible(true);
+            $property = $reflection->getProperty('app');
 
             return $property->getValue($this->handleExceptions);
         });
@@ -339,7 +339,7 @@ public function testForgetApp()
     public function testHandlerForgetsPreviousApp()
     {
         $appResolver = fn () => with(new ReflectionClass($this->handleExceptions), function ($reflection) {
-            $property = tap($reflection->getProperty('app'))->setAccessible(true);
+            $property = $reflection->getProperty('app');
 
             return $property->getValue($this->handleExceptions);
         });

tests/Foundation/Console/CliDumperTest.php

@@ -121,7 +121,6 @@ public function testWhenIsFileViewIsNotViewCompiled()
 
         $reflection = new ReflectionClass($dumper);
         $method = $reflection->getMethod('isCompiledViewFile');
-        $method->setAccessible(true);
         $isCompiledViewFile = $method->invoke($dumper, $file);
 
         $this->assertFalse($isCompiledViewFile);
@@ -140,7 +139,6 @@ public function testWhenIsFileViewIsViewCompiled()
 
         $reflection = new ReflectionClass($dumper);
         $method = $reflection->getMethod('isCompiledViewFile');
-        $method->setAccessible(true);
         $isCompiledViewFile = $method->invoke($dumper, $file);
 
         $this->assertTrue($isCompiledViewFile);
@@ -160,7 +158,6 @@ public function testGetOriginalViewCompiledFile()
 
         $reflection = new ReflectionClass($dumper);
         $method = $reflection->getMethod('getOriginalFileForCompiledView');
-        $method->setAccessible(true);
 
         $this->assertSame($original, $method->invoke($dumper, $compiled));
     }
@@ -179,7 +176,6 @@ public function testWhenGetOriginalViewCompiledFileFails()
 
         $reflection = new ReflectionClass($dumper);
         $method = $reflection->getMethod('getOriginalFileForCompiledView');
-        $method->setAccessible(true);
 
         $this->assertSame($original, $method->invoke($dumper, $compiled));
     }

tests/Foundation/Http/HtmlDumperTest.php

@@ -116,7 +116,6 @@ public function testWhenIsFileViewIsNotViewCompiled()
 
         $reflection = new ReflectionClass($dumper);
         $method = $reflection->getMethod('isCompiledViewFile');
-        $method->setAccessible(true);
         $isCompiledViewFile = $method->invoke($dumper, $file);
 
         $this->assertFalse($isCompiledViewFile);
@@ -133,7 +132,6 @@ public function testWhenIsFileViewIsViewCompiled()
 
         $reflection = new ReflectionClass($dumper);
         $method = $reflection->getMethod('isCompiledViewFile');
-        $method->setAccessible(true);
         $isCompiledViewFile = $method->invoke($dumper, $file);
 
         $this->assertTrue($isCompiledViewFile);
@@ -151,7 +149,6 @@ public function testGetOriginalViewCompiledFile()
 
         $reflection = new ReflectionClass($dumper);
         $method = $reflection->getMethod('getOriginalFileForCompiledView');
-        $method->setAccessible(true);
 
         $this->assertSame($original, $method->invoke($dumper, $compiled));
     }
@@ -168,7 +165,6 @@ public function testWhenGetOriginalViewCompiledFileFails()
 
         $reflection = new ReflectionClass($dumper);
         $method = $reflection->getMethod('getOriginalFileForCompiledView');
-        $method->setAccessible(true);
 
         $this->assertSame($original, $method->invoke($dumper, $compiled));
     }

tests/Foundation/Testing/BootTraitsTest.php

@@ -36,12 +36,12 @@ public function testSetUpAndTearDownTraits()
         $testCase = new TestCaseWithTrait('foo');
 
         $method = new ReflectionMethod($testCase, 'setUpTraits');
-        tap($method)->setAccessible(true)->invoke($testCase);
+        $method->invoke($testCase);
 
         $this->assertTrue($testCase->setUp);
 
         $method = new ReflectionMethod($testCase, 'callBeforeApplicationDestroyedCallbacks');
-        tap($method)->setAccessible(true)->invoke($testCase);
+        $method->invoke($testCase);
 
         $this->assertTrue($testCase->tearDown);
     }

tests/Foundation/Testing/DatabaseMigrationsTest.php

@@ -38,8 +38,6 @@ private function __reflectAndSetupAccessibleForProtectedTraitMethod($methodName)
             $methodName
         );
 
-        $migrateFreshUsingReflection->setAccessible(true);
-
         return $migrateFreshUsingReflection;
     }
 

tests/Foundation/Testing/RefreshDatabaseTest.php

@@ -38,8 +38,6 @@ private function __reflectAndSetupAccessibleForProtectedTraitMethod($methodName)
             $methodName
         );
 
-        $migrateFreshUsingReflection->setAccessible(true);
-
         return $migrateFreshUsingReflection;
     }
 

tests/Foundation/Testing/Traits/CanConfigureMigrationCommandsTest.php

@@ -22,8 +22,6 @@ private function __reflectAndSetupAccessibleForProtectedTraitMethod($methodName)
             $methodName
         );
 
-        $migrateFreshUsingReflection->setAccessible(true);
-
         return $migrateFreshUsingReflection;
     }
 

tests/Integration/Queue/JobDispatchingTest.php

@@ -78,7 +78,6 @@ public function testUniqueJobLockIsReleasedForJobDispatchedAfterResponse()
     {
         // get initial terminatingCallbacks
         $terminatingCallbacksReflectionProperty = (new \ReflectionObject($this->app))->getProperty('terminatingCallbacks');
-        $terminatingCallbacksReflectionProperty->setAccessible(true);
         $startTerminatingCallbacks = $terminatingCallbacksReflectionProperty->getValue($this->app);
 
         UniqueJob::dispatchAfterResponse('test');