[10.x] Mark commands as isolatable #46925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just throwing this idea out here, but would this be a good use case for an attribute? |
milwad-dev
pushed a commit
to milwad-dev/framework
that referenced
this pull request
May 12, 2023
* Ability to set default for --isolated option * set default exit code * Update Command.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
|
It is an excellent feature that I have been searching for. |
|
Laravel will acquire an atomic lock for that command: https://laravel.com/docs/10.x/artisan#isolatable-commands This will work across instances as long as every instance uses the same cache connection. |
|
@dennisprudlo thanks for great expalanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #44743 there was merit for marking commands as isolated by default. The work was subsequently changed to an
--isolatedflag to reduce the chances of breakages.This PR allows the developer to configure the default values:
protected $isolated = true;is equivalent to manually passing--isolatedprotected $isolatedCommandExitCode = 12;is equivalent to manually passing--isolated=12