Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Config markdown theme ignored #46317

Closed
wants to merge 8 commits into from
Closed

Conversation

AEM5299
Copy link
Contributor

@AEM5299 AEM5299 commented Mar 2, 2023

This is a bug introduced by my earlier PR #46200. It is always defaulting to default theme unless explicitly set in the Mailable class, which ignored the config option (reported by @pikseli). This should fix that bug.

I am not sure if this is the best approach, so open to any suggestions or other ideas.

@driesvints
Copy link
Member

Thanks @AEM5299. But I'm afraid this PR can't be merged as it contains breaking changes to class constructs and replaces properties. I'll try to have a look myself.

@driesvints driesvints marked this pull request as draft March 2, 2023 07:49
@AEM5299
Copy link
Contributor Author

AEM5299 commented Mar 2, 2023

We can get the value from config instead of always setting it to 'default' here. We can also change Markdown to not be a singleton, since it correctly sets the config value on construction.

@driesvints
Copy link
Member

driesvints commented Mar 2, 2023

I think the former would work. You can maybe use Container::getInstance() to resolve the config value.

@driesvints driesvints marked this pull request as ready for review March 2, 2023 09:21
@u01jmg3
Copy link
Contributor

u01jmg3 commented Mar 2, 2023

@AEM5299: not sure if it's intentional but your PR no longer has any test coverage.

@taylorotwell
Copy link
Member

Can you please fix conflicts?

@taylorotwell
Copy link
Member

Fixed here: 791f8ea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants