-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.x] Config markdown theme ignored #46317
Conversation
Thanks @AEM5299. But I'm afraid this PR can't be merged as it contains breaking changes to class constructs and replaces properties. I'll try to have a look myself. |
We can get the value from config instead of always setting it to |
I think the former would work. You can maybe use |
@AEM5299: not sure if it's intentional but your PR no longer has any test coverage. |
Can you please fix conflicts? |
Fixed here: 791f8ea |
This is a bug introduced by my earlier PR #46200. It is always defaulting to
default
theme unless explicitly set in the Mailable class, which ignored the config option (reported by @pikseli). This should fix that bug.I am not sure if this is the best approach, so open to any suggestions or other ideas.