Use InteractsWithDictionary in Eloquent collection #46196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the behaviour of database collections when using non-scalar primary keys by using the same dictionary behaviour used elsewhere.
alcaeus
force-pushed
the
eloquent-collection-dictionary
branch
from
6a77163
to
d7f2afb
Compare
driesvints
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the behaviour of database collections when using non-scalar primary keys by using the same dictionary behaviour used elsewhere.
The use case is the jenssegers/laravel-mongodb library, where identifiers may be non-scalar values. Using
InteractsWithDictionaryfixes this for all stringable objects directly, but also would allow us to support other complex objects by overriding thegetDictionaryKeymethod without having to override all methods making use of the dictionary.