Skip to content

[9.x] Improve test for filled in Helpers #43894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2022
Merged

[9.x] Improve test for filled in Helpers #43894

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b41ba83
[9.x] Improve test for filled in Helpers
moharami Aug 26, 2022
2bf51d9
[9.x] Improve test for filled in Helpers
moharami Aug 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions tests/Support/SupportHelpersTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use ArrayAccess;
use ArrayIterator;
use Countable;
use Illuminate\Contracts\Support\Htmlable;
use Illuminate\Support\Env;
use Illuminate\Support\Optional;
Expand Down Expand Up @@ -39,6 +40,21 @@ public function testClassBasename()
$this->assertSame('Baz', class_basename('Baz'));
}

public function testFilled()
{
$this->assertFalse(filled(null));
$this->assertFalse(filled(''));
$this->assertFalse(filled(' '));
$this->assertTrue(filled(10));
$this->assertTrue(filled(true));
$this->assertTrue(filled(false));
$this->assertTrue(filled(0));
$this->assertTrue(filled(0.0));

$object = new SupportTestCountable();
$this->assertFalse(filled($object));
}

public function testValue()
{
$this->assertSame('foo', value('foo'));
Expand Down Expand Up @@ -903,3 +919,11 @@ public function getIterator(): Traversable
return new ArrayIterator($this->items);
}
}

class SupportTestCountable implements Countable
{
public function count(): int
{
return 0;
}
}