[9.x] Enhance column modifying

[hafezdivandari]

Before this PR, we were manually map Laravel column types to its Doctrine equivalent and many types were missing, this PR uses each database platform own map instead. So we can support modifying many more columns, e.g. double, float, jsonb, set, timeTz, timestamp (no need to register a custom Doctrine type class), timestampTz, tinyText, unsignedDecimal, unsignedDouble, unsignedFloat, year, etc.

It also fix a bug when modifying a binary column that were being changed to LONGBLOB instead of BLOB.

Here is the Doctrine type mapping of:

• MySQL: https://github.com/doctrine/dbal/blob/de42378d0e521fd45d375020472caf37a003d289/src/Platforms/AbstractMySQLPlatform.php#L1041-L1072
• PostreSQL: https://github.com/doctrine/dbal/blob/de42378d0e521fd45d375020472caf37a003d289/src/Platforms/PostgreSQLPlatform.php#L1083-L1125
• SQLServer: https://github.com/doctrine/dbal/blob/de42378d0e521fd45d375020472caf37a003d289/src/Platforms/SQLServerPlatform.php#L1392-L1423
• SQLite : https://github.com/doctrine/dbal/blob/de42378d0e521fd45d375020472caf37a003d289/src/Platforms/SqlitePlatform.php#L663-L696

[driesvints]

There are several breaking changes to method signatures in this PR.

[hafezdivandari]

@driesvints I fixed that in a new commit and reverted all changes on method signatures.

[taylorotwell]

Why use MySQL platform? What if user is using SQL Server?

[hafezdivandari]

Laravel binary type maps to Doctrine blob type and only MySQL uses length option:

• MySQL: https://github.com/doctrine/dbal/blob/36b9ffc15c31598baa2a37b1abdd5b860d5c164f/src/Platforms/AbstractMySQLPlatform.php#L1270-L1289
• SQLServer: https://github.com/doctrine/dbal/blob/36b9ffc15c31598baa2a37b1abdd5b860d5c164f/src/Platforms/SQLServerPlatform.php#L1614-L1617
• PostreSQL: https://github.com/doctrine/dbal/blob/36b9ffc15c31598baa2a37b1abdd5b860d5c164f/src/Platforms/PostgreSQLPlatform.php#L1273-L1276
• SQLite: https://github.com/doctrine/dbal/blob/36b9ffc15c31598baa2a37b1abdd5b860d5c164f/src/Platforms/SqlitePlatform.php#L857-L860

[taylorotwell]

What does this do?

[hafezdivandari]

Laravel timestamp type maps to Doctrine datetime type:

• MySQL supports timestamp if $options['platformOptions']['version'] is set:
  • Mapping: https://github.com/doctrine/dbal/blob/36b9ffc15c31598baa2a37b1abdd5b860d5c164f/src/Platforms/AbstractMySQLPlatform.php#L1176
  • Declaration: https://github.com/doctrine/dbal/blob/36b9ffc15c31598baa2a37b1abdd5b860d5c164f/src/Platforms/AbstractMySQLPlatform.php#L290-L297
  • Declares the version option here: https://github.com/doctrine/dbal/blob/36b9ffc15c31598baa2a37b1abdd5b860d5c164f/src/Platforms/AbstractPlatform.php#L4451
• PostreSQL supports timestamp and timestampTz:
  • Mapping: https://github.com/doctrine/dbal/blob/36b9ffc15c31598baa2a37b1abdd5b860d5c164f/src/Platforms/PostgreSQLPlatform.php#L1179-L1180
  • Declaration: https://github.com/doctrine/dbal/blob/36b9ffc15c31598baa2a37b1abdd5b860d5c164f/src/Platforms/PostgreSQLPlatform.php#L1025-L1036
• SQLite platform maps timestamp to datetime:
  • Mapping: https://github.com/doctrine/dbal/blob/36b9ffc15c31598baa2a37b1abdd5b860d5c164f/src/Platforms/SqlitePlatform.php#L778
  • Declaration: https://github.com/doctrine/dbal/blob/36b9ffc15c31598baa2a37b1abdd5b860d5c164f/src/Platforms/SqlitePlatform.php#L319-L322
• SQLServer has no mapping for timestamp (doesn't support)

[taylorotwell]

What does "version" = true even mean though?

[hafezdivandari]

They use this option on MySQL and DB2 only on datetime type. That's the only way to convert datetime to timestamp. but I don't know why they call it "version" if that's the question.

[taylorotwell]

What does this do? Why is it needed?

[hafezdivandari]

Only PostgreSQL supports jsonb:

• Maps jsonb to json: https://github.com/doctrine/dbal/blob/36b9ffc15c31598baa2a37b1abdd5b860d5c164f/src/Platforms/PostgreSQLPlatform.php#L1169
• Uses jsonb option: https://github.com/doctrine/dbal/blob/36b9ffc15c31598baa2a37b1abdd5b860d5c164f/src/Platforms/PostgreSQLPlatform.php#L1315-L1322

[taylorotwell]

Why MySQL specific?

[hafezdivandari]

Only MySQL uses length option on text type:

• MySQL: https://github.com/doctrine/dbal/blob/36b9ffc15c31598baa2a37b1abdd5b860d5c164f/src/Platforms/AbstractMySQLPlatform.php#L266-L285
• PostgreSQL: https://github.com/doctrine/dbal/blob/3.4.x/src/Platforms/PostgreSQLPlatform.php#L1082-L1085
• SQLServer: https://github.com/doctrine/dbal/blob/36b9ffc15c31598baa2a37b1abdd5b860d5c164f/src/Platforms/SQLServerPlatform.php#L1313-L1316
• SQLite: https://github.com/doctrine/dbal/blob/36b9ffc15c31598baa2a37b1abdd5b860d5c164f/src/Platforms/SqlitePlatform.php#L514-L517

[taylorotwell]

Please mark as ready for review when all questions are answered. Thanks.

[hafezdivandari]

@taylorotwell Thank you for reviewing this PR. I answered all.

[taylorotwell]

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.