[9.x] Add failing tests $request->query() no longer can retrieve array query string#40599
Closed
crynobone wants to merge 2 commits intolaravel:9.xfrom
Closed
[9.x] Add failing tests $request->query() no longer can retrieve array query string#40599crynobone wants to merge 2 commits intolaravel:9.xfrom
$request->query() no longer can retrieve array query string#40599crynobone wants to merge 2 commits intolaravel:9.xfrom
Conversation
Contributor
|
This is due to the following deprecation https://github.com/symfony/symfony/blob/v5.4.2/src/Symfony/Component/HttpFoundation/InputBag.php#L39 (which was added via symfony/symfony#34363) In order for array parameters to work with Symfony 6 if (is_null($key)) {
return $this->$source->all();
}
return $this->$source->get($key, $default);to if (is_null($key)) {
return $this->$source->all();
}
return $this->$source->all()[$key] ?? $default; |
Member
Author
|
@X-Coder264 feel free to create a PR. Mine is more just to verify there is a bug and the other test PR to 8.x will be merged to 9.x eventually. |
Contributor
|
@crynobone Done -> #40609 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact same code from #40598 for Laravel 9
Signed-off-by: Mior Muhammad Zaki crynobone@gmail.com