[8.x] Add Http::configure() method

[ryangjchandler]

This pull request introduces a new Http::configure() method that can be used to modify all PendingRequest objects globally.

class AppServiceProvider extends ServiceProvider
{
    public function boot() {
        Http::configure(function (PendingRequest $request) {
            $request->withHeaders(['custom' => 'yes!']);
        });
    }
}

In this scenario, all requests made from the app will have this custom header applied.

[taylorotwell]

Does it make sense for this to be invoked right before the request is actually sent? That way you could inspect other information about the request before configuring it further - for example, what if you only wanted to add some headers if the URI matched a given value?

[ryangjchandler]

@taylorotwell Yeah, fair point. My personal use case was for all requests, regardless of URL but you're right, that would make a lot more sense. It's getting late here so I'll update this tomorrow if that's okay?

[taylorotwell]

OK

[ryangjchandler]

@taylorotwell I've updated the logic to configure the request at the top of the PendingRequest::send method. Wasn't sure whether it should be at the start of that method or the PendingRequest::sendRequest method.

[taylorotwell]

Hmm - I dunno, something about this still seems kinda clunky to use. How do I inspect the request for a header or look at its final URI? How can I see what data it has?

[ryangjchandler]

Happy to close this and leave it be if you think it's not worth it. There are user-land workarounds like constructing a base client that has the correct options already.

Without dedicated methods on the request object to inspect the Guzzle options, there's no easy way to do the things you mentioned.

[taylorotwell]

Yeah - here's how I would do this:

In service provider:

Http::macro('github', function () {
    return Http::withHeaders([
        'X-First' => 'foo',
    ])->baseUrl('https://github.com');
});

In code:

Http::github()->get('/');

May document this 🤔

[ryangjchandler]

@taylorotwell Yeah, this is an alternative approach. Thanks for taking a look though! :)

I guess the only drawback here is that lack of autocomplete/intellisense, but easily fixed with ide-helper or a stubs file.

[taylorotwell]

Embrace the dynamic language ❤️

[dammy001]

🔥🔥🔥

[frknasir]

Yeah - here's how I would do this:

In service provider:

Http::macro('github', function () {
    return Http::withHeaders([
        'X-First' => 'foo',
    ])->baseUrl('https://github.com');
});

In code:

Http::github()->get('/');

May document this 🤔

Rad!