[8.x] Add a default timeout in the HTTP client #40180
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
requested changes
Dec 27, 2021
| @@ -162,6 +162,7 @@ public function __construct(Factory $factory = null) | |||
|
|
|||
| $this->options = [ | |||
| 'http_errors' => false, | |||
| 'timeout' => 10, | |||
There was a problem hiding this comment.
10 seconds is probably too low for a lot of people. I'd recommend going with:
'connect_timeout' => 10,
'timeout' => 15,
like in https://github.com/GrahamCampbell/Guzzle-Factory/blob/5.0/src/GuzzleFactory.php.
|
Please target 9.x. This change will break an app I work on because it has API calls that last 3 mins (I did not design it 🙃). |
|
A default timeout is a great idea. I've had queue workers get stuck because HTTP calls timed-out in a weird way (even though supervisor reported they were working fine). |
|
A default timeout is sure a good idea, but shouldn't this be treat as a breaking change? |
|
@themsaid I agree we should probably send this to 9.x / master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
Moved to the 9.x release: #40187