Skip to content

[9.x] Removes core class aliases from the skeleton #40062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 20, 2021
Merged

[9.x] Removes core class aliases from the skeleton #40062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
110f443
Allows to remove core class `app.aliases` from the skeleton
nunomaduro Dec 15, 2021
68e9820
Removes `Redis` alias
nunomaduro Dec 15, 2021
a5bae5a
Merges configurations
nunomaduro Dec 15, 2021
b4f9441
Reverts changes on Register Facades
nunomaduro Dec 17, 2021
59f04e5
Adds `Facade::defaultAliases`
nunomaduro Dec 17, 2021
db6fba9
Apply fixes from StyleCI
taylorotwell Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions src/Illuminate/Support/Facades/Facade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
namespace Illuminate\Support\Facades;

use Closure;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Arr;
use Illuminate\Support\Js;
use Illuminate\Support\Str;
use Mockery;
use Mockery\LegacyMockInterface;
use RuntimeException;
Expand Down Expand Up @@ -243,6 +247,55 @@ public static function clearResolvedInstances()
static::$resolvedInstance = [];
}

/**
* Get the application default aliases.
*
* @return array
*/
public static function defaultAliases()
{
return [
'App' => App::class,
'Arr' => Arr::class,
'Artisan' => Artisan::class,
'Auth' => Auth::class,
'Blade' => Blade::class,
'Broadcast' => Broadcast::class,
'Bus' => Bus::class,
'Cache' => Cache::class,
'Config' => Config::class,
'Cookie' => Cookie::class,
'Crypt' => Crypt::class,
'Date' => Date::class,
'DB' => DB::class,
'Eloquent' => Model::class,
'Event' => Event::class,
'File' => File::class,
'Gate' => Gate::class,
'Hash' => Hash::class,
'Http' => Http::class,
'Js' => Js::class,
'Lang' => Lang::class,
'Log' => Log::class,
'Mail' => Mail::class,
'Notification' => Notification::class,
'Password' => Password::class,
'Queue' => Queue::class,
'RateLimiter' => RateLimiter::class,
'Redirect' => Redirect::class,
'Request' => Request::class,
'Response' => Response::class,
'Route' => Route::class,
'Schema' => Schema::class,
'Session' => Session::class,
'Storage' => Storage::class,
'Str' => Str::class,
'URL' => URL::class,
'Validator' => Validator::class,
'View' => View::class,
];
}

/**
* Get the application instance behind the facade.
*
Expand Down
15 changes: 15 additions & 0 deletions tests/Integration/Support/FacadesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
namespace Illuminate\Tests\Integration\Support;

use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Facade;
use Orchestra\Testbench\TestCase;
use ReflectionClass;

class FacadesTest extends TestCase
{
Expand Down Expand Up @@ -39,4 +41,17 @@ public function testFacadeResolvedCanResolveCallbackAfterAccessRootHasBeenResolv

$this->assertTrue(isset($_SERVER['__laravel.authResolved']));
}

public function testDefaultAliases()
{
$defaultAliases = Facade::defaultAliases();

foreach ($defaultAliases as $alias => $abstract) {
$this->assertTrue(class_exists($alias));
$this->assertTrue(class_exists($abstract));

$reflection = new ReflectionClass($alias);
$this->assertSame($abstract, $reflection->getName());
}
}
}